-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to yarn #29908
Migrate to yarn #29908
Conversation
Fixes #29906 |
|
|
2753ac7
to
850d129
Compare
Codecov Report
@@ Coverage Diff @@
## master #29908 +/- ##
=========================================
Coverage 58.18% 58.18%
Complexity 18459 18459
=========================================
Files 1092 1092
Lines 63620 63620
=========================================
Hits 37015 37015
Misses 26605 26605 Continue to review full report at Codecov.
|
tests/drone/yarn-install.sh
Outdated
@@ -6,4 +6,5 @@ if [[ "$(pwd)" == "$(cd "$(dirname "$0")"; pwd -P)" ]]; then | |||
exit 1 | |||
fi | |||
|
|||
exec npm install --prefix build | |||
cd build | |||
exec yarn install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe exec yarn install --modules-folder build/node_modules
won't require any dir change like before with npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried that - did not work out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, I noticed that yarn doesn't have the --prefix
argument but also doesn't complain if you use it... see makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn install --cwd build
850d129
to
775b526
Compare
👍 for @DeepDiver1975's changes. Need review for mine. @felixheidecke if you're familiar with yarn you could check them 😄 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
TEST:
make
still worksTEST:
make dist
still worksTEST: ownCloud still runs fine
Expecting CI failures. Will require
npm install -g yarn
on CI.build server require yarn
Do we want to backport this ?